Client re-enables work requests

Message boards : BOINC client : Client re-enables work requests
Message board moderation

To post messages, you must log in.

AuthorMessage
Marky-UK

Send message
Joined: 12 Jul 06
Posts: 35
United Kingdom
Message 8913 - Posted: 20 Mar 2007, 10:48:57 UTC

The 5.8.16 release contained the following change:

- core client: add optional <detach_when_done> and <dont_request_more_work> flags to account element in account manager reply messages. See acct_mgt.php

The aim of this was to allow account managers to optionally specify those flags to give better control over the client.

The problem is the behaviour of the client has changed if those flags are missing from the account manager reply. If <dont_request_more_work> is missing, the client turns work requests back on. The <dont_request_more_work> will always be missing with account managers that have not been updated to support 5.8.16.

If the <dont_request_more_work> flag is missing from the account manager reply, the client behaviour should not be changing - the client should be using the state of dont_request_more_work that existed before the account manager was contacted.

Anyone agree? Is this a bug?
ID: 8913 · Report as offensive
Nicolas

Send message
Joined: 19 Jan 07
Posts: 1179
Argentina
Message 8920 - Posted: 20 Mar 2007, 14:41:11 UTC

I think that's in fact the only way the AMS has to disable detach_when_done setting: not sending the tag.
ID: 8920 · Report as offensive
Marky-UK

Send message
Joined: 12 Jul 06
Posts: 35
United Kingdom
Message 8929 - Posted: 20 Mar 2007, 17:39:07 UTC - in response to Message 8920.  
Last modified: 20 Mar 2007, 17:40:03 UTC

IMHO, the new <dont_request_more_work> account manager flag is not optional (as the change history says) if its absence changes the behaviour of the client (by always turning work requests back on).

Also, this change moves responsibility for the "no new work" setting to the account manager, and effectively removes the ability to control it via BOINC Manager - if NNW is set on the client via the Manager, the setting may get overridden the next time the account manager is contacted. This would be even worse if there isn't currently a way for the client to tell the account manager the current state of the "no new work" setting.

Being able to enable/disable "no new work" via an account manager would be quite useful, but being able to set it via the Manager too is very important.
ID: 8929 · Report as offensive
Nicolas

Send message
Joined: 19 Jan 07
Posts: 1179
Argentina
Message 8933 - Posted: 20 Mar 2007, 21:45:18 UTC

I would also like a way to set <detach_when_done> from a GUI RPC (even if the official manager has no button to send the message).
ID: 8933 · Report as offensive
Profile KSMarksPsych
Avatar

Send message
Joined: 30 Oct 05
Posts: 1239
United States
Message 8940 - Posted: 21 Mar 2007, 3:29:52 UTC

David's checked in a fix for this...


David 20 Mar 2007
! - core client: if "no more work" or "detach when done" tag
! is missing from account manager reply, don't change value.
! Note: this is implemented using new
! OPTIONAL_BOOL and OPTIONAL_DOUBLE types
! that may be useful elsewere as well.
!
! client/
! acct_mgr.C,h

Kathryn :o)
ID: 8940 · Report as offensive
Richard Haselgrove
Volunteer tester
Help desk expert

Send message
Joined: 5 Oct 06
Posts: 5082
United Kingdom
Message 8948 - Posted: 21 Mar 2007, 9:08:35 UTC
Last modified: 21 Mar 2007, 9:09:23 UTC

Could a similar approach be used for this problem (simple GUI discarding custom settings in global_prefs_override.xml), discussed a few days ago in the Number of CPUs changing thread?

David did say his new technique might be useful elsewhere....
ID: 8948 · Report as offensive

Message boards : BOINC client : Client re-enables work requests

Copyright © 2024 University of California.
Permission is granted to copy, distribute and/or modify this document under the terms of the GNU Free Documentation License, Version 1.2 or any later version published by the Free Software Foundation.