Possible tag issue in forums

Message boards : Web interfaces : Possible tag issue in forums
Message board moderation

To post messages, you must log in.

1 · 2 · Next

AuthorMessage
Janus

Send message
Joined: 28 Aug 05
Posts: 10
Message 21818 - Posted: 15 Dec 2008, 17:10:10 UTC
Last modified: 15 Dec 2008, 17:22:48 UTC

Supposedly I should be unable to post the following according to a bug report:
<cc_config>
<options>
<http_1_0>1</http_1_0>
</options>
</cc_config>
<cc_config>
<options>
<http_1_0>1</http_1_0>
</options>
</cc_config>

<cc_config>
<options>
<http_1_0>1</http_1_0>
</options>
</cc_config>

<cc_config>
<options>
<http_1_0>1</http_1_0>
</options>
</cc_config>
ID: 21818 · Report as offensive
Profile Jord
Volunteer tester
Help desk expert
Avatar

Send message
Joined: 29 Aug 05
Posts: 14730
Netherlands
Message 21819 - Posted: 15 Dec 2008, 17:11:33 UTC - in response to Message 21818.  

No, here it works. It doesn't work in the Seti forums.

It doesn't work in PM either... let me PM it to you. :-)
ID: 21819 · Report as offensive
Richard Haselgrove
Volunteer tester
Help desk expert

Send message
Joined: 5 Oct 06
Posts: 4598
United Kingdom
Message 21820 - Posted: 15 Dec 2008, 17:14:57 UTC - in response to Message 21819.  

No, here it works. It doesn't work in the Seti forums.

It doesn't work in PM either... let me PM it to you. :-)

No, it's OK in every forum I've seen - if anything, we have too many of them at SETI (heavy use/quoting of app_info.xml).

It's the PM system which is broken, here and at SETI.
ID: 21820 · Report as offensive
Janus

Send message
Joined: 28 Aug 05
Posts: 10
Message 21821 - Posted: 15 Dec 2008, 17:20:07 UTC
Last modified: 15 Dec 2008, 17:21:38 UTC

Alright, I've been able to reproduce this on my test project. Looking into it. Does this have a trac ticket?
ID: 21821 · Report as offensive
Profile Jord
Volunteer tester
Help desk expert
Avatar

Send message
Joined: 29 Aug 05
Posts: 14730
Netherlands
Message 21822 - Posted: 15 Dec 2008, 17:21:28 UTC
Last modified: 15 Dec 2008, 17:22:18 UTC

Something eats BBCode tags as well on the Seti forums, when putting it in code or pre tags. Let me test here.

[img]http://link_to_elsewhere.jpeg[/img]

[img]http://link_to_elsewhere.jpeg[/img]


Preview shows the above as nothing being there.
Posting shows the "broken" image link... it shouldn't activate the code in any way. not in the code tags.
ID: 21822 · Report as offensive
Janus

Send message
Joined: 28 Aug 05
Posts: 10
Message 21823 - Posted: 15 Dec 2008, 17:23:44 UTC - in response to Message 21822.  

Something eats BBCode tags as well on the Seti forums, when putting it in code or pre tags. Let me test here

That's a seperate issue.
ID: 21823 · Report as offensive
Profile Jord
Volunteer tester
Help desk expert
Avatar

Send message
Joined: 29 Aug 05
Posts: 14730
Netherlands
Message 21824 - Posted: 15 Dec 2008, 17:24:28 UTC - in response to Message 21823.  
Last modified: 15 Dec 2008, 17:25:08 UTC

Something eats BBCode tags as well on the Seti forums, when putting it in code or pre tags. Let me test here

That's a seperate issue.

Agreed, just flagging it. ;)

You saw what I meant in the PM, though.
ID: 21824 · Report as offensive
Janus

Send message
Joined: 28 Aug 05
Posts: 10
Message 21825 - Posted: 15 Dec 2008, 17:29:23 UTC

Update: Found an issue in inc/pm.inc:pm_send() : A call to striptags() on the content text.
This is most likely a bug - but fixing it requires checking whether any other part of the code relied on the tags being stripped already there. So this may take a little while to fix.
ID: 21825 · Report as offensive
Profile Jord
Volunteer tester
Help desk expert
Avatar

Send message
Joined: 29 Aug 05
Posts: 14730
Netherlands
Message 21827 - Posted: 15 Dec 2008, 17:38:04 UTC
Last modified: 15 Dec 2008, 17:38:47 UTC

testing the other thing.

<tag_it>

Editing post... No, here it still works after edits.
ID: 21827 · Report as offensive
Janus

Send message
Joined: 28 Aug 05
Posts: 10
Message 21828 - Posted: 15 Dec 2008, 17:49:53 UTC

Fixed the first issue you described, the change should eventually end up here.
ID: 21828 · Report as offensive
Profile Jord
Volunteer tester
Help desk expert
Avatar

Send message
Joined: 29 Aug 05
Posts: 14730
Netherlands
Message 21829 - Posted: 15 Dec 2008, 17:56:19 UTC - in response to Message 21828.  

Thanks for the quick fix, Janus.
ID: 21829 · Report as offensive
Richard Haselgrove
Volunteer tester
Help desk expert

Send message
Joined: 5 Oct 06
Posts: 4598
United Kingdom
Message 21830 - Posted: 15 Dec 2008, 17:59:15 UTC

And thanks from me too.

What's the best way of alerting/requesting SETI to apply the new code? That's where we really need it. (And probably SETI Beta too, though they usually do them in tandem).
ID: 21830 · Report as offensive
Richard Haselgrove
Volunteer tester
Help desk expert

Send message
Joined: 5 Oct 06
Posts: 4598
United Kingdom
Message 21831 - Posted: 15 Dec 2008, 18:05:16 UTC

And while we're all here: this fancy new coloured background that Jord has had for a few weeks. I suppose it's triggered by one, other or both of his status tags. Useful: I can see it picking out Moderator or Project Scientist posts in a discussion thread.

But it doesn't work very well at SETI Beta, where everybody, without exception, is given a <Volunteer tester> tag. Is there any way the background could be made a bit more selective?
ID: 21831 · Report as offensive
Profile Jord
Volunteer tester
Help desk expert
Avatar

Send message
Joined: 29 Aug 05
Posts: 14730
Netherlands
Message 21832 - Posted: 15 Dec 2008, 18:05:18 UTC - in response to Message 21830.  

Email or PM Eric Korpela or Matt Lebowski. That they change it during the maintenance outage tomorrow.
ID: 21832 · Report as offensive
Profile Jord
Volunteer tester
Help desk expert
Avatar

Send message
Joined: 29 Aug 05
Posts: 14730
Netherlands
Message 21833 - Posted: 15 Dec 2008, 18:07:22 UTC - in response to Message 21831.  
Last modified: 15 Dec 2008, 18:08:19 UTC

And while we're all here: this fancy new coloured background that Jord has had for a few weeks. I suppose it's triggered by one, other or both of his status tags. Useful: I can see it picking out Moderator or Project Scientist posts in a discussion thread.

Go to your account, forum preferences, uncheck Highlight special users and save changes.

Or ask Eric to exclude the role of <volunteer tester> from these highlights.
ID: 21833 · Report as offensive
Richard Haselgrove
Volunteer tester
Help desk expert

Send message
Joined: 5 Oct 06
Posts: 4598
United Kingdom
Message 21834 - Posted: 15 Dec 2008, 18:22:17 UTC - in response to Message 21833.  

And while we're all here: this fancy new coloured background that Jord has had for a few weeks. I suppose it's triggered by one, other or both of his status tags. Useful: I can see it picking out Moderator or Project Scientist posts in a discussion thread.

Go to your account, forum preferences, uncheck Highlight special users and save changes.

Or ask Eric to exclude the role of <volunteer tester> from these highlights.

It's really not worth pestering him - there are other things I would much prefer he spent his time on.

Hadn't seen the 'Highlight special users' option before (don't often visit those pages). Strange thing is, the preference is present and checked in my SETI Main account, but there is no highlighting on the SETI Main forums: must be in some sort of half-updated state.

Do you think if I can get Matt or Eric to update the code for the PM-bugfix tomorrow, I'll become a 'special user' too, along with all the other volunteer testers? (who are also automatically tagged at main, if their accounts can be linked up)
ID: 21834 · Report as offensive
Profile Jord
Volunteer tester
Help desk expert
Avatar

Send message
Joined: 29 Aug 05
Posts: 14730
Netherlands
Message 21836 - Posted: 15 Dec 2008, 18:31:52 UTC - in response to Message 21834.  
Last modified: 15 Dec 2008, 18:47:13 UTC

Do you think if I can get Matt or Eric to update the code for the PM-bugfix tomorrow, I'll become a 'special user' too, along with all the other volunteer testers? (who are also automatically tagged at main, if their accounts can be linked up)

Aren't you special already? (Annoying, irritating, etc. etc. ;-))

They don't do special roles on the forums there, but for the volunteer tester and volunteer developers roles. The latter should be given by the admin, the former is given when you attach to Beta with the same email address as used on Seti main.

I've only managed to get rid of mine by changing the email address on Beta to something else.
ID: 21836 · Report as offensive
Richard Haselgrove
Volunteer tester
Help desk expert

Send message
Joined: 5 Oct 06
Posts: 4598
United Kingdom
Message 21837 - Posted: 15 Dec 2008, 18:34:23 UTC - in response to Message 21832.  

Email or PM Eric Korpela or Matt Lebowski. That they change it during the maintenance outage tomorrow.

Done.
ID: 21837 · Report as offensive
Richard Haselgrove
Volunteer tester
Help desk expert

Send message
Joined: 5 Oct 06
Posts: 4598
United Kingdom
Message 21838 - Posted: 15 Dec 2008, 18:35:14 UTC - in response to Message 21836.  

Do you think if I can get Matt or Eric to update the code for the PM-bugfix tomorrow, I'll become a 'special user' too, along with all the other volunteer testers? (who are also automatically tagged at main, if their accounts can be linked up)

Aren't you special already? (Annoying, irritating, etc. etc. ;-))

And frequently blue in the face, if not in the background.
ID: 21838 · Report as offensive
Janus

Send message
Joined: 28 Aug 05
Posts: 10
Message 21840 - Posted: 15 Dec 2008, 18:57:31 UTC

Fixed the other issue as well with the exception that it only works for CODE blocks - not PRE blocks.
The reason is that CODE blocks use divs with stylesheets allowing us to use escaping of [ to break out of the BBCode parsing. Pre tags are implemented directly as HTML pre tags and hence do not allow escaping (the escape code would show up instead of the actual char).

The solution is of course to make PRE blocks do the same thing as CODE blocks do now:
1) Add a style for pre divs and convince all projects to update their CSS
2) Make 'pre's do what 'code's do now in text_transform.php

I left that as an excersize for the reader.
ID: 21840 · Report as offensive
1 · 2 · Next

Message boards : Web interfaces : Possible tag issue in forums

Copyright © 2021 University of California. Permission is granted to copy, distribute and/or modify this document under the terms of the GNU Free Documentation License, Version 1.2 or any later version published by the Free Software Foundation.