Message boards :
Questions and problems :
New Boinc version - very sparse event log
Message board moderation
Previous · 1 · 2
Author | Message |
---|---|
Send message Joined: 25 Nov 05 Posts: 1654 |
Getting back on topic: Richard Perhaps the problem isn't in this "memset" routine, but in what calls it. The input data may work for memset, but not for the replacement. And a printf at the start may show what's wrong with the data. |
Send message Joined: 5 Oct 06 Posts: 5082 |
Thanks for getting us back on topic - we could use some lateral thinking, or in-depth knowledge of C++, right now. Juha used to pop in at times like this, but I haven't seen him around for a while. I think the proximate cause - removing memset - is probably an unnecessary red-herring. The original compiler warning - "clearing an object of non-trivial type ‘struct PCI_INFO’; use assignment or value-initialization instead" probably didn't need such drastic action (LOG_FLAGS is a simpler structure: we are initialising, not clearing). "But the moving finger writes; and, having writ, moves on: nor all thy piety nor wit shall lure it back to cancel half a line, nor all thy tears wash out a word of it." (Omar Khayyam). So, we need a replacement that works, and that will pass the scrutiny of the gatekeeper of the code himself. Back of a postcard, anyone? |
Send message Joined: 29 Aug 05 Posts: 15483 |
Thanks for getting us back on topic - we could use some lateral thinking, or in-depth knowledge of C++, right now. Juha used to pop in at times like this, but I haven't seen him around for a while.I've asked Jason to come take a look. You never know. |
Send message Joined: 29 Aug 05 Posts: 15483 |
As for the bug, who else noticed that between 7.16 being sent out for testing and it being released to public, there was just 5 days? Testing April 3rd, Release April 8th. And then just two people who actually tested it. I don't think we ever had such a short time between testing and release, especially not during another worldwide crisis that would keep people occupied that way. I long for the days of Rom this way. He'd also have jumped on top of these reports and already released a client with a fix. If only for testing. But alas. |
Send message Joined: 5 Oct 06 Posts: 5082 |
I have some (very slight) sympathy with David over this one. v7.16.5 was actually made available for download (for Windows only) towards the end of February. I noticed it, and downloaded it at the beginning of March. No announcement was made, but David later said that he was waiting for someone (himself?) to make a Mac build. I tested it, but I was checking for fixes to the problems we already knew about. My machines already have cc_config.xml files, so this problem didn't show up - even when I deliberately went looking for it (I deleted the log flag entries in the file, not the file itself). I'm afraid I don't have the patience and mindset to go back to ground zero and test new releases on clean machines, as the very bureaucratic 'box ticking' alpha test regime requires. So I missed it. David's test strategy almost relies on a continual turnover of testers - old ones retire, new one arrive with new machines. I do agree with you about missing Rom, though. |
Send message Joined: 29 Aug 05 Posts: 15483 |
I should've seen it, as I installed BOINC clean on my system and ran it bare bones for a while. But I don't run it every day and when I do, I don't check the messages every time. So I have missed it as well. Got a message back from Jason, he's peeking in. |
Send message Joined: 29 Aug 05 Posts: 15483 |
From Jason: static const LOG_FLAGS x;Should be in the class definition LOG_FLAGS, rather than inside LOG_FLAGS::init() ( but see later ** ) Edit: and Would have been nice if LOG_FLAGS were defined in log_flags.h/.cpp , but whatever, found it in cc_config. Edit: And Richard in the CC. Easier to do it via email for now. :) |
Send message Joined: 5 Oct 06 Posts: 5082 |
Yes, I'm getting the copies now. Probably best not to interrupt the thought processes - I'll nip out for my allowed daily exercise (and pick up the newspaper), catch up when I get back. |
Send message Joined: 29 Aug 05 Posts: 15483 |
Jason: Simplest 'potential' fix I can think of, that won't require changing references to log_flags throughout the codebase. : |
Send message Joined: 5 Oct 06 Posts: 5082 |
But where would the actual defaults be set? In the STRUCT definition in the header, as in my second attempt yesterday? I think that might be in the narrow-column-formatted one, but it's hard to read. I'll switch to a development machine, and try it out. |
Send message Joined: 29 Aug 05 Posts: 15483 |
With |
Send message Joined: 5 Oct 06 Posts: 5082 |
Jason:Well, I've made that change, and set the three standard values to true as in post 97743 It seems to start OK with or without cc_config.xml, showing appropriate inital config report and Event Log messages; I can change settings through the GUI, and they work properly, too. I'll try Linux next: what else do I need to test before I make a PR? |
Send message Joined: 5 Oct 06 Posts: 5082 |
And it seems to work in Linux, too: Fri 17 Apr 2020 16:57:41 BST | | cc_config.xml not found - using defaults Fri 17 Apr 2020 16:57:41 BST | | Starting BOINC client version 7.16.6 for x86_64-pc-linux-gnu Fri 17 Apr 2020 16:57:41 BST | | log flags: file_xfer, sched_ops, task ... Fri 17 Apr 2020 16:58:57 BST | | Re-reading cc_config.xml Fri 17 Apr 2020 16:58:57 BST | | Config: GUI RPC allowed from any host Fri 17 Apr 2020 16:58:57 BST | | Config: GUI RPCs allowed from: Fri 17 Apr 2020 16:58:57 BST | | Config: don't check file sizes Fri 17 Apr 2020 16:58:57 BST | | Config: don't use VirtualBox Fri 17 Apr 2020 16:58:57 BST | | Config: event log limit 3000 lines Fri 17 Apr 2020 16:58:57 BST | | log flags: file_xfer, sched_ops, task, sched_op_debug, unparsed_xmlI'll break for coffee, but it's looking good. |
Send message Joined: 5 Oct 06 Posts: 5082 |
Well, Charlie has said some nice things about my proposed solution - but David is more interested in adding yet more new features than fixing the ones he broke. I despair sometimes. |
Send message Joined: 31 Dec 18 Posts: 285 |
Well, Charlie has said some nice things about my proposed solution - but David is more interested in adding yet more new features than fixing the ones he broke. I despair sometimes. That sounds pretty normal :-) |
Copyright © 2024 University of California.
Permission is granted to copy, distribute and/or modify this document
under the terms of the GNU Free Documentation License,
Version 1.2 or any later version published by the Free Software Foundation.