Changes between Version 3 and Version 4 of Expectations_of_Code_Review


Ignore:
Timestamp:
09/25/17 08:36:41 (4 months ago)
Author:
knreed
Comment:

--

Legend:

Unmodified
Added
Removed
Modified
  • Expectations_of_Code_Review

    v3 v4  
    1 = Reviewer Expectations for Code Review = #ExpectationsofCodeReview-ReviewerExpectations
    2  * Have verified that Definition of Done has been completed
    3  * Visual inspection of code to see that it does what it needs to and doesn't do what is not reported
    4  * Confirmed that all comments and questions raised in discussion of the pull request have been resolved
    5  * If possible, a reviewer should build and test the code changes
    6  * Merging a pull request is a statement of "I believe this code is of good quality"
    7  * Check that consensus voting has resulted in approval of each issue resolved with the pull request (see governance document for details)
    8  * Check that consensus voting has resulted in approval of the pull request itself (see governance document for details)
     1This page has been moved to https://github.com/BOINC/boinc-policy/blob/master/Expectations_of_Code_Review.md