Changes between Version 2 and Version 3 of Expectations_of_Code_Review


Ignore:
Timestamp:
Sep 1, 2017, 2:58:51 PM (7 years ago)
Author:
Kevin Reed
Comment:

--

Legend:

Unmodified
Added
Removed
Modified

  • Expectations_of_Code_Review

    v2 v3  
    1 = Reviewer Expectations = #ExpectationsofCodeReview-ReviewerExpectations
     1= Reviewer Expectations for Code Review = #ExpectationsofCodeReview-ReviewerExpectations
    22 * Have verified that Definition of Done has been completed
    33 * Visual inspection of code to see that it does what it needs to and doesn't do what is not reported
    44 * Confirmed that all comments and questions raised in discussion of the pull request have been resolved
    5  * If possible, a reviewer should build and test the code changes 
    6  * Merging a pull request is a statement of "I believe this code is of good quality"  
     5 * If possible, a reviewer should build and test the code changes
     6 * Merging a pull request is a statement of "I believe this code is of good quality"
    77 * Check that consensus voting has resulted in approval of each issue resolved with the pull request (see governance document for details)
    88 * Check that consensus voting has resulted in approval of the pull request itself (see governance document for details)