Ticket #837 (closed Defect: fixed)

Opened 10 months ago

Last modified 10 months ago

Suspend/Resume buttons not updating

Reported by: MarkJ Assigned to: charlief
Priority: Minor Milestone: Undetermined
Component: Manager Version:
Keywords: suspend,resume Cc: Pepo

Description

BOINC 6.6.3, installed as single-user under WinXP.

Select a running task from the tasks tab. Press suspend. Button should change to resume but does not. Similarly select a suspended task and select resume. Once started button does not change to suspend.

In both cases selecting another task and then re-selecting the original task does show the correct buttons. See attached screen shots.

Also the text under the projects column is pushed to the right as it makes room for a scroll bar for the buttons until the window is resized. The scroll bar goes away when the window is large enough, however the text under the project column does not move back to the left. It does this under 6.5.0 and 6.6.2 as well. BOINC 6.2.19 works correctly.

Attachments

Suspend_Resume1.JPG (187.7 kB) - added by MarkJ on 01/29/09 03:28:56.
Suspend/resume buttons1
Suspend_Resume2.JPG (189.9 kB) - added by MarkJ on 01/29/09 03:29:41.
Suspend/resume buttons2

Change History

01/29/09 03:28:56 changed by MarkJ

  • attachment Suspend_Resume1.JPG added.

Suspend/resume buttons1

01/29/09 03:29:41 changed by MarkJ

  • attachment Suspend_Resume2.JPG added.

Suspend/resume buttons2

01/29/09 19:27:44 changed by charlief

  • owner changed from romw to charlief.

This bug has 2 parts. The Suspend button not changing to Resume is valid, and I will examine that. The second part is that the left hand column of the list is shifted right.

As far as I can see, the shift to the right has nothing to do with making room for a scroll bar; it is always present, but only on Windows. I spent quite a bit of time trying to fix that some time ago, but it is not even under the control of wxWidgets. The drawing is being done by Microsoft's native List-View control, which shifts the text to the right as soon as we associate an image list with the list. The image list has the up and down arrows we use to indicate the sort column; even though we add the icons only to the labels, the native list control shifts the first column of each row to the right. Among many other things, I spent quite a bit of time triying to find a way to draw the up or down sort arrow without using an image list, but could not fnd any way to do so reliably.

This does not happen with the non-native list control used on the Mac and Linux. As far as I can tell, there is no way to fix it for Windows, but it is only a minor cosmetic issue. The whole point of merging the old Grid View features into the old Accessible View was to enable Windows' accessibility features for users with disabilities, such as those using screen readers. This requires the use of the native list control.

01/29/09 23:03:44 changed by charlief

  • status changed from new to closed.
  • resolution set to fixed.

(In [17078]) MGR: call UpdateSelection?() from OnListRender?() instead of from RestoreSelections?(). Fixes #837.

01/29/09 23:06:00 changed by charlief

(In [17079]) MGR: call UpdateSelection?() from OnListRender?() instead of from RestoreSelections?(). Fixes #837.

01/29/09 23:08:07 changed by charlief

Fixed Suspend / Resume button bug for 6.6.4. Will not fix the shift to the right.

(in reply to: ↑ description ) 01/30/09 10:29:40 changed by Pepo

  • cc set to Pepo.

Replying to MarkJ:

Select a running task from the tasks tab. Press suspend. Button should change to resume but does not. Similarly select a suspended task and select resume. Once started button does not change to suspend.

Not exactly. The subsequent button presses do change their state, but are out of sync (one state late). When the button should display "suspen", it displays "resume" and vice versa.

If this page is incomplete or incorrect, please edit it or add it to the wiki to-do list. To do this, you must be logged in; click Login or Register above.