Ticket #78 (closed Defect: fixed)

Opened 1 year ago

Last modified 7 months ago

Broken delete_file [patch]

Reported by: Nicolas Assigned to: ballen
Priority: Minor Milestone: Undetermined
Component: Server - Scheduler Version:
Keywords: delete_file patch Cc:

Description

delete_file is storing incorrect data on the msg_to_host database table. Variety and xml fields are empty. This is because the mth structure is cleared after these fields are set, on function delete_host_file. Patch attached.

Additionally, there is extra code to check if -host_id is 'all':

if(!strcmp(argv[++i], "all")) {
    host_id = 0;
}

but some lines below the program exits if host_id == 0. Also, the scheduler has no special code to handle this. The messages will never be sent because host '0' will never communicate. I'm not sure how this would be fixed, since I don't know what was the intended behavior.

Attachments

delete_file.diff (0.7 kB) - added by Nicolas on 04/19/07 09:32:38.
Patch

Change History

04/19/07 09:32:38 changed by Nicolas

  • attachment delete_file.diff added.

Patch

10/09/07 19:06:33 changed by Nicolas

  • summary changed from Broken delete_file to Broken delete_file [patch].

Add patch availability to ticket title.

10/20/07 17:28:18 changed by Nicolas

  • keywords changed from delete_file to delete_file patch.

12/21/07 12:57:50 changed by davea

  • status changed from new to closed.
  • resolution set to fixed.

(In [14434]) - API: check for messages from client 10X a second;

this will allow smoother CPU throttling

- delete_file: bug fixes (from Nicolas Alvarez). Fixes #78


If this page is incomplete or incorrect, please edit it or add it to the wiki to-do list. To do this, you must be logged in; click Login or Register above.