Ticket #703 (reopened Defect)

Opened 1 year ago

Last modified 3 months ago

BOINC should check for errors in xml files without unparsed_xml flag on.

Reported by: Ageless Assigned to: davea
Priority: Major Milestone: Undetermined
Component: Client - Daemon Version: 6.2.14
Keywords: Cc: Ageless, Pepo

Description

This bug came up through Michael Tughan, who found that his self-built Macintosh application for one of the projects was dropped by BOINC 6.2.14 as soon as it started.

Both Rom and I checked his app_info.xml file and we could find nothing wrong with it at first. Eventually after checking all other possibilities, our attention returned to the app_info.xml file, where we did find a missing / in an end tag.

So the question is, shouldn't BOINC be checking for things like this, especially when using user supplied applications? Perhaps <unparsed_xml> should be on all the time?

Change History

(follow-up: ↓ 3 ) 07/24/08 14:27:42 changed by romw

I'm thinking that user modifiable files should report XML parsing errors even if the unparsed_xml flag isn't defined.

cc_config.xml and app_info.xml are pretty good canidates.

07/24/08 14:27:47 changed by davea

  • status changed from new to closed.
  • resolution set to fixed.

(In [15670]) - client: report all errors in parsing app_info.xml files

Fixes #703

(in reply to: ↑ 1 ) 07/28/08 16:59:57 changed by Pepo

  • cc changed from Ageless to Ageless, Pepo.

Replying to romw:

I'm thinking that user modifiable files should report XML parsing errors even if the unparsed_xml flag isn't defined. cc_config.xml and app_info.xml are pretty good canidates.

If these two, then IMO global_prefs_override.xml too.

08/11/08 11:52:32 changed by Ageless

  • status changed from closed to reopened.
  • resolution deleted.

Reopening and requesting that global_prefs.xml and global_prefs_override.xml are also added to the check.

Having just checked whether or not global_prefs_override.xml is checked for any errors or false flags, I found it isn't being checked.

For testing I added <bongo_jerry>1</bongo_jerry> to the file.
I then went to Read local prefs file from the Advanced menu, it isn't registered as a wrong tag.
Trying to stop&restart BOINC, it isn't registered as a wrong tag.

So what if someone has his file full of typos? Not everyone uses BOINC Manager, which may spell it correctly.

08/11/08 13:59:30 changed by Nicolas

Malformed XML should give errors. Unrecognized tags should give errors only if you ask for it.

Otherwise, a new preference will annoy the user with errors if he has an older BOINC.

02/25/09 14:40:27 changed by romw

  • milestone changed from 6.6 to Undetermined.
If this page is incomplete or incorrect, please edit it or add it to the wiki to-do list. To do this, you must be logged in; click Login or Register above.