Ticket #417 (closed Defect: fixed)

Opened 2 years ago

Last modified 2 years ago

nowork_skip causes team info to disappear from client

Reported by: Eric Myers Assigned to: davea
Priority: Major Milestone: Undetermined
Component: Client - Work Fetch Policy Version:
Keywords: RPC, scheduler Cc: Ageless

Description

When a project sets the option "nowork_skip" the scheduler does not even bother to contact the database if there is no work. As a result, the response back to the client does not indicate the team or updated stats. On the client the user's team disappears, which causes great concern and confusion. The RPC exchange needs to be adjusted so that no *change* is made to the user's team affiliation. The same may apply to other information, but the loss of team is the most visible and distressing.

Change History

09/21/07 05:36:55 changed by Eric Myers

The venue is also lost, and this is also noticeable and distressing.

09/21/07 06:21:52 changed by Ageless

  • priority changed from Undetermined to Major.

09/21/07 10:36:30 changed by Nicolas

If I understand this correctly, the change needs to be done on the client side so that lack of team/venue tags leaves info untouched instead of clearing it out. If so, component needs to be changed (I won't change it till I get confirmation). Problem is, when you aren't attached to any team (and there is work or nowork_skip is disabled), does it get an empty tag or no tag at all?

04/15/08 04:53:52 changed by Eric Myers

  • owner changed from ballen to davea.
  • component changed from Server - Scheduler to Client - Work Fetch Policy.

We seem to have another instance of this behavior. I modified the scheduler on Pirates@Home to use the "wrong version" check to only allow 6.1.14, to give the alpha testers some work involving trickles. This also causes the team to disappear. See http://pirates.spy-hill.net/forum_thread.php?id=926#7528

I agree with Bruce's comment completely that the primary change probably needs to be in the client, but how it's done depends on what the server sends, which may also need a coordinated change in the sever. I'm changing the Component for the ticket to "Client", but maybe not correctly.

04/15/08 05:02:29 changed by Eric Myers

Ooops, I attributed Nicolas' comment to Bruce (because I saw Bruce owned the ticket). Sorry.

04/29/08 04:27:32 changed by Ageless

  • cc set to Ageless.

ticket:633 is duplicate of this one.

05/15/08 17:14:50 changed by davea

  • status changed from new to closed.
  • resolution set to fixed.

(In [15232]) - scheduler: there were several situations where the scheduler

would send a reply without having looked up the user and team in the DB; e.g.:

  • client version# is too low
  • DB is down
  • host is blacklisted It would then send a full scheduler reply, including a blank team name and other missing info.

Fix this by setting reply.nucleus_only initially (this causes a minimal reply to be sent) and clearing it only if the host/user/team lookup succeeds. Fixes #417, #633 (I think)

If this page is incomplete or incorrect, please edit it or add it to the wiki to-do list. To do this, you must be logged in; click Login or Register above.