Ticket #363 (closed Defect: fixed)

Opened 1 year ago

Last modified 8 months ago

Per-day time preferences work incorrectly

Reported by: Didactylos Assigned to: davea
Priority: Major Milestone: 5.10
Component: Client - Daemon Version:
Keywords: time advanced-preferences preferences patch Cc:

Description

Per-day time preferences work incorrectly. An example: set Monday to process from 10:00-14:00. Leave the network times for Monday unspecified. This has the side-effect of forcing the network times for Monday to "Always".

Why does this happen? BOINC doesn't maintain separate preferences for CPU and network, they are both shoved into the same struct. It gets zeroed before use, and 0-0 means "Always". Because Monday is marked as "present", this 0-0 overrides the desired network times.

A secondary bug:

The advanced preferences dialog fails to always display the correct customised days. This can be reproduced by setting, say, a CPU time for Monday, and a network time for Thursday. Close the dialog, and the network time will have gone when you reopen the dialog. Perversely, the settings are saved correctly.

Attachments

time.patch (30.0 kB) - added by Didactylos on 08/23/07 15:26:46.
Patch for custom times bugs. (With a couple of corrections.)

Change History

08/04/07 03:28:37 changed by Ageless

You don't say which version of BOINC this happens in.

Yet since you want it fixed by 5.10, have you tried any of the latest versions? A lot of fixes to the daily processor usage and network preferences have been done in 5.10.9 and above (Windows and Mac).

08/04/07 14:49:22 changed by Didactylos

These bugs are in HEAD, so far as I know. Since new features are still creeping into 5.10, there's plenty of room still to fix actual bugs. Also, this isn't a platform-specific bug.

I've found another: if you set a day to "always", it is explicitly not written out - the setting is completely ignored.

08/05/07 19:18:15 changed by Didactylos

The patch fixes all the bugs in this ticket, and also includes the day_prefs in global preferences, as well as the override (they were omitted in GLOBAL_PREFS::write()).

The XML format remains the same, but the semantics in GLOBAL_PREFS have been altered. The CPU and net connect times have been separated, so they can use the same week/timespan format. This significantly simplifies the code.

08/07/07 23:45:36 changed by Didactylos

Forgot the copy constructor. Colour me daft...

08/23/07 15:26:46 changed by Didactylos

  • attachment time.patch added.

Patch for custom times bugs. (With a couple of corrections.)

08/25/07 02:53:35 changed by charlief

  • status changed from new to closed.
  • resolution set to fixed.

(In [13454]) Preferences: fix #363: per-day time preferences work incorrectly; MGR: use cached preferences if connected to pre-5.10.18 client..

08/25/07 02:54:36 changed by charlief

(In [13455]) Preferences: fix #363: per-day time preferences work incorrectly; MGR: use cached preferences if connected to pre-5.10.18 client.

10/20/07 17:28:47 changed by Nicolas

  • keywords changed from time advanced_preferences preferences to time advanced_preferences preferences patch.

11/17/07 05:20:29 changed by Didactylos

  • keywords changed from time advanced_preferences preferences patch to time advanced-preferences preferences patch.
If this page is incomplete or incorrect, please edit it or add it to the wiki to-do list. To do this, you must be logged in; click Login or Register above.