Segmentation fault with boincmgr 5.10.28
Message boards :
BOINC client :
Segmentation fault with boincmgr 5.10.28
Message board moderation
| Author | Message |
|---|---|
 Send message Joined: 30 Aug 05 Posts: 5 
|
Now that I have Suse 10.3 64-bit running on a nice new machine, I tried again to install BOINC from the current linux release boinc_ubuntu_5.10.28_x86_64-pc-linux-gnu.sh. It works mostly fine, but there is a segmentation error when I close the advanced view: SIGSEGV: segmentation violation Checking further with a local build, I find that CAdvancedFrame::UpdateRefreshTimerInterval is called from within the class destructor, and the timer object is referenced after it has been destroyed: (gdb) bt I have fixed that locally by setting the corresponding pointers to NULL after the timers are deleted (all three for consistency) and checking the offending pointer for validity before it is used. Here are the changes to clientgui/AdvancedFrame.cpp: ~/software/boinc/boinc_core_release_5_10_28/clientgui> diff AdvancedFrame.cpp.~1~ AdvancedFrame.cpp
285a286
> m_pRefreshStateTimer = NULL;
290a292
> m_pFrameRenderTimer = NULL;
295a298
> m_pFrameListPanelRenderTimer = NULL;
2114c2117
< if (m_pFrameListPanelRenderTimer->IsRunning()) {
---
> if (m_pFrameListPanelRenderTimer != NULL && m_pFrameListPanelRenderTimer->IsRunning()) {
The corresponding changes are also relevant for version 5.10.41 ID: 15299 ·  |
|
Send message Joined: 19 Jan 07 Posts: 1179 
|
I have fixed that locally by setting the corresponding pointers to NULL after the timers are deleted (all three for consistency) and checking the offending pointer for validity before it is used. Here are the changes to clientgui/AdvancedFrame.cpp: I had trouble applying your patch. The first three applied without indentation, and the fourth line refused to patch at all. Then I found it was because the forum removed spaces! Apparently [code] doesn't keep spaces, [pre] does. But [pre] leaves empty lines in the middle. Great! We have no decent forum tag for posting code... Anyway, here's the same in unified diff format: http://www.pastebin.ca/896870. It applies over trunk, instead of the 5.10.28 tag. If you contribute more patches in the future (which are really welcome! BOINC has a developer deficit), please use the unified format. If you used SVN to get the sourcecode, you don't even need to keep a backup, SVN already does that for you. Just go to the top 'boinc' directory, and type 'svn diff'. ID: 15303 · |
|
Send message Joined: 30 Aug 05 Posts: 5
|
I had trouble applying your patch. ... Thanks for the quick response. I will look at svn diff and have noted www.pastebin.ca for future use. Perhaps we need a trac ticket for "pre and code tags need fixing"? ID: 15306 · |
|
Send message Joined: 19 Jan 07 Posts: 1179
|
Perhaps we need a trac ticket for "pre and code tags need fixing"? I'm not sure if it's a problem on the forum code everywhere, or just something on this forum. ID: 15310 · |
|
Send message Joined: 30 Aug 05 Posts: 5
|
Perhaps we need a trac ticket for "pre and code tags need fixing"? I think it's a general problem. I have just posted this text over at einstein@home, and we see the spacing problems you noticed - also the placement of a blank line before the quote/code/pre block is inconsistent. ID: 15312 · |
 Send message Joined: 26 Aug 05 Posts: 164 |
Now that I have Suse 10.3 64-bit running on a nice new machine, I tried again to install BOINC from the current linux release boinc_ubuntu_5.10.28_x86_64-pc-linux-gnu.sh. It works mostly fine, but there is a segmentation error when I close the advanced view:SIGSEGV: segmentation violation I have commited this patch ----- Rom BOINC Development Team, U.C. Berkeley My Blog ID: 15586 · |
Copyright © 2024 University of California.
Permission is granted to copy, distribute and/or modify this document
under the terms of the GNU Free Documentation License,
Version 1.2 or any later version published by the Free Software Foundation.